Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3267 xmir2xmir tests #3317

Closed

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Aug 6, 2024

Closes #3267


PR-Codex overview

This PR focuses on adding XcopCondition to skip tests without xcop. It also includes YAML files for xmir2xmir tests.

Detailed summary

  • Added XcopCondition to skip tests without xcop
  • Added YAML files for xmir2xmir tests
  • Updated XSL files with examples in YAML
  • Added MIT License to YAML files

The following files were skipped due to too many changes: eo-maven-plugin/src/test/resources/org/eolang/maven/xmir2xmir/aligns-test-classes.yaml, eo-maven-plugin/src/test/java/org/eolang/maven/Xmir2Xmir.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please review

@levBagryansky
Copy link
Member Author

@yegor256 please check

1 similar comment
@maxonfjvipon
Copy link
Member

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented Aug 8, 2024

@levBagryansky @maxonfjvipon didn't we agree that comparing XML to XML is a bad idea and we should use XPath instead?

@maxonfjvipon
Copy link
Member

@yegor256 we decided that we can try to implement it using xcop since it produces quite strong structure of xml

@levBagryansky
Copy link
Member Author

@yegor256 Such tests have one significant advantage: they clearly show how xsl transformation works.

@maxonfjvipon
Copy link
Member

@levBagryansky thanks for your contribution, but the final decision is that such testing is a bad idea

@levBagryansky
Copy link
Member Author

@maxonfjvipon ohh, ok

@levBagryansky levBagryansky deleted the 3267-xmir2xmir_tests branch September 6, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove-high-level-inner-classes.xsl:27-28: Create...
3 participants