Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3222): extened logs on pull #3223

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jun 10, 2024

Closes: #3222


PR-Codex overview

This PR enhances error handling in the PullMojo class and adds a new method in ForeignTojo. It also introduces a test to validate error logging functionality.

Detailed summary

  • Improved error handling in PullMojo by handling exceptions when pulling objects.
  • Added a new method discoveredAt() in ForeignTojo class to get the discovered location.
  • Introduced a test to verify error logging functionality in PullMojo.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 10, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c5bbe04 into objectionary:master Jun 10, 2024
22 checks passed
@rultor
Copy link
Contributor

rultor commented Jun 10, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

@maxonfjvipon
Copy link
Member Author

@yegor256 let's make a new release with tag 0.38.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's unclear where problematic object is used
3 participants