Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#2535): added tests and puzzles for XMIR to phi-calculus translator #2569

Merged
merged 3 commits into from
Nov 1, 2023
Merged

feat(#2535): added tests and puzzles for XMIR to phi-calculus translator #2569

merged 3 commits into from
Nov 1, 2023

Conversation

Graur
Copy link
Contributor

@Graur Graur commented Oct 31, 2023 •
edited by pr-codex bot
Loading

#2535

PR-Codex overview

This PR focuses on adding functionality to the TranslateToPhiMojo class in the eo-maven-plugin module.

Detailed summary

  • Updated the pom.xml file to change the maximum value from 7 to 8.
  • Added a new static class TranslateToPhi in FakeMaven.java to iterate over a list of classes.
  • Added a new class TranslateToPhiMojo in TranslateToPhiMojo.java to read XMIR files and translate them to phi-calculus expressions.
  • Added a new test class TranslateToPhiMojoTest in TranslateToPhiMojoTest.java to test the functionality of TranslateToPhiMojo.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Graur Graur marked this pull request as ready for review October 31, 2023 08:57
@Graur
Copy link
Contributor Author

Graur commented Oct 31, 2023

@maxonfjvipon Please, take a look

maxonfjvipon
maxonfjvipon suggested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Graur good one, just one comment from my side

eo-maven-plugin/src/main/java/org/eolang/maven/PhiTranslatorMojo.java Outdated Show resolved Hide resolved
@Graur
Copy link
Contributor Author

Graur commented Nov 1, 2023

@maxonfjvipon Could you please take a look one more time?

maxonfjvipon
maxonfjvipon approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Graur LGTM! Thanks

@Graur
Copy link
Contributor Author

Graur commented Nov 1, 2023

@yegor256 Please, take a look

@yegor256
Copy link
Member

yegor256 commented Nov 1, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 1, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 98a8659 into objectionary:master Nov 1, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Nov 1, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 21min)

@Graur Graur deleted the 2535 branch November 2, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Graur @yegor256 @rultor @maxonfjvipon