Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2516: Refactored the test #2518

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Oct 2, 2023

Closes #2516

PR-Codex overview

Focus of this PR:

Enable tests in the eo-runtime by removing the usage of assert-that and refactoring the affected tests.

Detailed summary:

  • Removed the usage of assert-that from the eo-runtime tests.
  • Refactored the rust-bind-not-fails and rust-error tests to enable them.
  • Updated the rust-tests.eo file to handle Rust insert failures in the Φ.org.eolang.rust-put-not-fails.put.α0 function.
  • Updated the rust-tests.eo file to handle Rust copy failures in the rust-copy-not-fails test.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please review

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky LGTM! Thanks

@levBagryansky
Copy link
Member Author

@yegor256 please take a look

@levBagryansky
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented Oct 6, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 6, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 196af6f into objectionary:master Oct 6, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 6, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 15min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-tests.eo:199-201: Enable the tests. After removing...
4 participants