Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2508): introduced eo.offline flag #2517

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Oct 2, 2023

Closes: #2508


PR-Codex overview

Focus of this PR:

This PR focuses on adding an offline flag to the EO Maven plugin, allowing users to pull objects from objectionaries in offline mode.

Detailed summary:

  • Added <offline> flag to eo-runtime/pom.xml
  • Added offline parameter to AssembleMojo class in eo-maven-plugin
  • Added offline parameter to PullMojo class in eo-maven-plugin
  • Added test cases for offline mode in FakeMaven, PullMojoTest, and AssembleMojoTest classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@Graur please review this one

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Nice solution, I like it!
@yegor256 Please have a look

@yegor256
Copy link
Member

yegor256 commented Oct 3, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 3, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 34912ed into objectionary:master Oct 3, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 3, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 14min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eo.offline flag for PullMojo
4 participants