-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#2211): memory
behaves as bytes
#2430
Merged
rultor
merged 8 commits into
objectionary:master
from
maxonfjvipon:feat/#2211/memory-behaves-as-bytes
Aug 24, 2023
Merged
feat(#2211): memory
behaves as bytes
#2430
rultor
merged 8 commits into
objectionary:master
from
maxonfjvipon:feat/#2211/memory-behaves-as-bytes
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Graur please review this one |
Graur
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon Looks good ot me, thanks!
@yegor256 Please, have a look
@yegor256 please have a look |
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2211
Desc: every time
memory
gets an object, it dataizes that object, converts to bytes and start behaves like this bytesPR-Codex overview
This PR focuses on updating the
EOmemory
object in the codebase.Detailed summary
EOmemory
now behaves as bytes.EOmemory
can be taken as an integer and updated.as-string
attribute is added toEOmemory
.