Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2211): memory behaves as bytes #2430

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 23, 2023

Closes: #2211

Desc: every time memory gets an object, it dataizes that object, converts to bytes and start behaves like this bytes


PR-Codex overview

This PR focuses on updating the EOmemory object in the codebase.

Detailed summary

  • EOmemory now behaves as bytes.
  • EOmemory can be taken as an integer and updated.
  • The written value can be read immediately after writing.
  • The as-string attribute is added to EOmemory.

The following files were skipped due to too many changes: eo-runtime/src/test/java/EOorg/EOeolang/EOmemoryTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@Graur please review this one

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Looks good ot me, thanks!
@yegor256 Please, have a look

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 24, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e36d608 into objectionary:master Aug 24, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 24, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory-tests.eo:32-38: Let's make sure memory can only...
4 participants