Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2299 Pulling with versions #2356

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 7, 2023

Ref: #1602

What's done:

  • Added ability to pull versioned objects
  • Enabled and refactored tests

PR-Codex overview

This PR focuses on improving object naming in the code.

Detailed summary

  • Updated the object method in ObjsDefault and Fake classes to accept an ObjectName instead of CommitHash and String.
  • Updated the Place constructor to accept an ObjectName instead of String.
  • Updated the object method in Objectionaries interface to accept an ObjectName instead of CommitHash and String.
  • Updated the pull method in PullMojo to accept an ObjectName instead of String.
  • Updated the pullsVersionedObjectSuccessfully test in PullMojoTest to use ObjectName instead of String.
  • Updated the pullsProbedVersionedObjectFromOneObjectionary test in PullMojoTest to use ObjectName instead of String.
  • Updated the pullsProbedVersionedObjectsFromDifferentObjectionaries test in PullMojoTest to use ObjectName instead of String.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please review this one

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Looks good to me, thank you!

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

yegor256 commented Aug 9, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 9, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6309ea9 into objectionary:master Aug 9, 2023
9 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 9, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@maxonfjvipon maxonfjvipon deleted the #2299-pulling-with-versions branch September 18, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants