-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2299 Pulling with versions #2356
Merged
rultor
merged 8 commits into
objectionary:master
from
maxonfjvipon:#2299-pulling-with-versions
Aug 9, 2023
Merged
#2299 Pulling with versions #2356
rultor
merged 8 commits into
objectionary:master
from
maxonfjvipon:#2299-pulling-with-versions
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@volodya-lombrozo please review this one |
volodya-lombrozo
suggested changes
Aug 7, 2023
eo-maven-plugin/src/test/java/org/eolang/maven/PullMojoTest.java
Outdated
Show resolved
Hide resolved
@volodya-lombrozo please have a look one more time |
volodya-lombrozo
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon Looks good to me, thank you!
@yegor256 please have a look |
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1602
What's done:
PR-Codex overview
This PR focuses on improving object naming in the code.
Detailed summary
object
method inObjsDefault
andFake
classes to accept anObjectName
instead ofCommitHash
andString
.Place
constructor to accept anObjectName
instead ofString
.object
method inObjectionaries
interface to accept anObjectName
instead ofCommitHash
andString
.pull
method inPullMojo
to accept anObjectName
instead ofString
.pullsVersionedObjectSuccessfully
test inPullMojoTest
to useObjectName
instead ofString
.pullsProbedVersionedObjectFromOneObjectionary
test inPullMojoTest
to useObjectName
instead ofString
.pullsProbedVersionedObjectsFromDifferentObjectionaries
test inPullMojoTest
to useObjectName
instead ofString
.