Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1602 Change delimiter between name and version #2353

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 4, 2023

Ref: #1602

What's done:

  • changed delimiter between name and version in EO object from | to #. Reason: | is illegal for windows
  • refactored tests

PR-Codex overview

This PR focuses on improving object name handling in the EO Maven plugin.

Detailed summary

  • Updated comments and method names for clarity.
  • Added a new method to check if a foreign tojo contains a specific object name.
  • Updated delimiter constant for EO object names.
  • Renamed a variable for consistency.
  • Updated XSL stylesheet to use the new delimiter in probe meta.
  • Updated tests to use the new object name format.

The following files were skipped due to too many changes: eo-maven-plugin/src/test/java/org/eolang/maven/PullMojoTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

maxonfjvipon commented Aug 4, 2023

@volodya-lombrozo please review this one, the PR is not so big as you might suppose

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Looks good to me, thanks!

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

yegor256 commented Aug 7, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 7, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 38bcaa0 into objectionary:master Aug 7, 2023
9 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 7, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@maxonfjvipon maxonfjvipon deleted the #1602-name-version-delimiter branch September 18, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants