Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2231 Broken head in syntax #2234

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 11, 2023

Closes: #2231


PR-Codex overview

Detailed summary

  • Deleted catches-same-line-name.yamleo-parser/src/test/resources/org/eolang/parser/typos/scoped-application-after-suffix.yaml
  • Added first and a > x (b > x) in eo field of eo-parser/src/test/resources/org/eolang/parser/typos/scoped-application-after-suffix.yaml
  • Changed count(error) from 1 to 2 in eo-parser/src/test/java/org/eolang/parser/SyntaxTest.java
  • Deleted skip: true in eo-parser/src/test/resources/org/eolang/parser/typos/broken-head.yaml
  • Changed regex pattern in eo-parser/src/main/java/org/eolang/parser/RedundantParentheses.java
  • Added # Comment(). in eo-parser/src/test/java/org/eolang/parser/RedundantParenthesesTest.java
  • Changed grammar rules in eo-parser/src/main/antlr4/org/eolang/parser/Program.g4
  • Added methods exitAbstraction and enterType in eo-parser/src/main/java/org/eolang/parser/XeListener.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon maxonfjvipon changed the title #2231 Fix EOLs in syntax #2231 Broken head in syntax Jul 11, 2023
@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@volodya-lombrozo pls, take a look

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Looks good to me, thanks.
@yegor256 Could you merge that changes, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 10min)

 \write18 enabled.
entering extended mode
/usr/local/bin/pygmentize
Latexmk: Getting log file 'eolang-paper.log'
Latexmk: Examining 'eolang-paper.fls'
Latexmk: Examining 'eolang-paper.log'
Latexmk: Found input bbl file 'eolang-paper.bbl'
Latexmk: Log file says output to 'eolang-paper.pdf'
Latexmk: Bibliography file(s) form .bcf file:
  ./main.bib
Latexmk: applying rule 'pdflatex'...
Rule 'pdflatex':  Reasons for rerun
Changed files or newly in use/created:
  eolang-paper.run.xml

------------
Run number 4 of rule 'pdflatex'
------------
------------
Running 'pdflatex  -recorder  -interaction=batchmode -shell-escape -halt-on-error "eolang-paper.tex"'
------------
This is pdfTeX, Version 3.141592653-2.6-1.40.25 (TeX Live 2023) (preloaded format=pdflatex)
 \write18 enabled.
entering extended mode
/usr/local/bin/pygmentize
Latexmk: Getting log file 'eolang-paper.log'
Latexmk: Examining 'eolang-paper.fls'
Latexmk: Examining 'eolang-paper.log'
Latexmk: Found input bbl file 'eolang-paper.bbl'
Latexmk: Log file says output to 'eolang-paper.pdf'
Latexmk: Bibliography file(s) form .bcf file:
  ./main.bib
Latexmk: All targets () are up-to-date
------------
Running 'texqc && texsc'
------------
File extention removed from "eolang-paper.tex"
[2150] LaTeX Warning: Unused global option(s):
[3125] Underfull \hbox (badness 1173) in paragraph at lines 188--188
[3131] Underfull \hbox (badness 1178) in paragraph at lines 188--188
3 LaTeX processing errors found in "eolang-paper.log"

+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
To github.com:objectionary/eo.git
 ! [rejected]            master -> master (fetch first)
error: failed to push some refs to '[email protected]:objectionary/eo.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
container 0067986965c0614a60430e69d30ec6df7e6090c826c70f62a00306c63fbc2643 is dead
Fri 14 Jul 2023 10:12:16 AM CEST

@maxonfjvipon
Copy link
Member Author

@yegor256 please try to merge one more time

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2e9c75c into objectionary:master Jul 14, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@maxonfjvipon maxonfjvipon deleted the #2231-broken-head branch September 18, 2023 12:10
@maxonfjvipon maxonfjvipon restored the #2231-broken-head branch September 18, 2023 12:11
@maxonfjvipon maxonfjvipon deleted the #2231-broken-head branch September 18, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken-head.yaml:1-4: The test is skipped because it...
4 participants