Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1602 Discover with versions #2228

Merged
merged 22 commits into from
Jul 14, 2023

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 10, 2023

Ref: #1602

What's done:

  • moved eo.versioned to SafeMojo to use it in every inherited Mojo
  • refactored RegisterMojo
  • Added ability to discover objects with versions
  • Refactored old and created new tests

PR-Codex overview

This PR focuses on implementing object versioning in the EO Maven Plugin.

Detailed summary:

  • Added a new flag withVersions to enable/disable object versioning.
  • Modified RegisterMojo to register external tojos with versions.
  • Modified DiscoverMojo to discover objects with versions.
  • Added tests to verify object discovery and registration with versions.

The following files were skipped due to too many changes: eo-maven-plugin/src/test/java/org/eolang/maven/RegisterMojoTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please review

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

@maxonfjvipon
Copy link
Member Author

@volodya-lombrozo please have a look one more time

Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon Looks good to me, thanks.

@maxonfjvipon
Copy link
Member Author

@yegor256 could you merge that changes please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9a7619f into objectionary:master Jul 14, 2023
9 checks passed
@rultor
Copy link
Contributor

rultor commented Jul 14, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants