-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1602 Discover with versions #2228
#1602 Discover with versions #2228
Conversation
@volodya-lombrozo please review |
eo-maven-plugin/src/main/java/org/eolang/maven/DiscoverMojo.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/RegisterMojoTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/test/java/org/eolang/maven/DiscoverMojoTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/java/org/eolang/maven/DiscoverMojo.java
Outdated
Show resolved
Hide resolved
@volodya-lombrozo please have a look one more time |
This reverts commit 6e20782
@volodya-lombrozo please have a look one more time |
eo-maven-plugin/src/test/java/org/eolang/maven/RegisterMojoTest.java
Outdated
Show resolved
Hide resolved
eo-maven-plugin/src/main/java/org/eolang/maven/DiscoverMojo.java
Outdated
Show resolved
Hide resolved
@volodya-lombrozo please have a look one more time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon Looks good to me, thanks.
@yegor256 could you merge that changes please? |
@rultor merge |
Ref: #1602
What's done:
eo.versioned
toSafeMojo
to use it in every inherited MojoRegisterMojo
PR-Codex overview
This PR focuses on implementing object versioning in the EO Maven Plugin.
Detailed summary:
withVersions
to enable/disable object versioning.RegisterMojo
to register external tojos with versions.DiscoverMojo
to discover objects with versions.