Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhDefault.vertex seems to be a deprecated feature #3421

Open
yegor256 opened this issue Oct 14, 2024 · 2 comments
Open

PhDefault.vertex seems to be a deprecated feature #3421

yegor256 opened this issue Oct 14, 2024 · 2 comments
Labels
bug good first issue help wanted

Comments

@yegor256
Copy link
Member

yegor256 commented Oct 14, 2024 •
edited
Loading

What's the point of keeping the PhDefault.vertex attribute if we don't have access to it from the language? I suggest we delete it entirely.

Also, we can get rid of our custom PhDefault.hashCode() and simply rely on the default implementation.
@yegor256 yegor256 added the bug label Oct 14, 2024
@yegor256
Copy link
Member Author

@maxonfjvipon WDYT?

@maxonfjvipon
Copy link
Member

@yegor256 I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yegor256 @maxonfjvipon