Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmir-to-phi doesn't fail on invalid attribute names #3322

Open
volodya-lombrozo opened this issue Aug 8, 2024 · 2 comments
Open

xmir-to-phi doesn't fail on invalid attribute names #3322

volodya-lombrozo opened this issue Aug 8, 2024 · 2 comments

Comments

@volodya-lombrozo
Copy link
Member

When I run xmir-to-phi goal I successfully convert all xmir files into PHI expressions. However, recently we realised that PHI expressions we get have a mistake:

I-0 ↦ Φ.org.eolang.param,

AFAIK, in PHI, all attribute labels must start with a lowercase letter.

You can read more about it here.
Expected behaviour: xmir-to-phi throws an error that is saying about the wrong naming.

Here is my configuration:

<plugin>
  <groupId>org.eolang</groupId>
  <artifactId>eo-maven-plugin</artifactId>
  <version>0.39.0</version>
  <executions>
    <execution>
      <id>convert-xmir-to-phi</id>
      <phase>process-classes</phase>
      <goals>
        <goal>xmir-to-phi</goal>
      </goals>
      <configuration>
        <phiInputDir>${opeo.modified}</phiInputDir>
        <phiOutputDir>${eo.phi.output}</phiOutputDir>
      </configuration>
    </execution>
  </executions>
</plugin>
@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Please, have a look

@yegor256
Copy link
Member

@maxonfjvipon would be great to add a check into xmir-to-phi, to fail faster

@yegor256 yegor256 changed the title xmir-to-phi doesn't check PHI labels xmir-to-phi doesn't fail on invalid attribute names Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants