From aa4542d8d92ee08c35b7d1ad1527f33793ba4915 Mon Sep 17 00:00:00 2001
From: Roman Korostinskiy <70313618+c71n93@users.noreply.github.com>
Date: Mon, 6 May 2024 20:30:29 +0300
Subject: [PATCH] #3160 get rid of parametrized test

---
 .../test/java/org/eolang/DataizedTest.java    | 96 ++++++++++++-------
 1 file changed, 64 insertions(+), 32 deletions(-)

diff --git a/eo-runtime/src/test/java/org/eolang/DataizedTest.java b/eo-runtime/src/test/java/org/eolang/DataizedTest.java
index 409775c188..c5dacdd7da 100644
--- a/eo-runtime/src/test/java/org/eolang/DataizedTest.java
+++ b/eo-runtime/src/test/java/org/eolang/DataizedTest.java
@@ -35,8 +35,6 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.ValueSource;
 
 /**
  * Test case for {@link Dataized}.
@@ -49,7 +47,8 @@ final class DataizedTest {
     /**
      * System property for maximum dataization log level.
      */
-    private static final String DATAIZATION_LOG = "max.dataization.log";
+    @SuppressWarnings("PMD.LongVariable")
+    private static final String MAX_DATAIZATION_LOG_PROPERTY = "max.dataization.log";
 
     @Test
     @Disabled
@@ -103,45 +102,78 @@ void logsWhenException() {
         );
     }
 
-    @ParameterizedTest
-    @ValueSource(ints = {1, 2})
-    void printsShortLogs(final int level) throws InterruptedException {
+    @Test
+    void printsShortLogs() throws InterruptedException {
+        final Logger log = Logger.getLogger("printsShortLogs");
+        final Level before = log.getLevel();
+        log.setLevel(Level.ALL);
+        final List<LogRecord> logs = new LinkedList<>();
+        final Handler hnd = new Hnd(logs);
+        log.addHandler(hnd);
+        final Thread thread = new DataizedLoggerThread(log, 1);
+        thread.start();
+        thread.join();
+        log.setLevel(before);
+        log.removeHandler(hnd);
+        MatcherAssert.assertThat(
+            "Number of log records should be equal to 1 in the case of short logs",
+            logs.size(),
+            Matchers.equalTo(1)
+        );
+    }
+
+    @Test
+    void printsLongLogs() throws InterruptedException {
         final Logger log = Logger.getLogger(Dataized.class.getName());
         final Level before = log.getLevel();
         log.setLevel(Level.ALL);
         final List<LogRecord> logs = new LinkedList<>();
         final Handler hnd = new Hnd(logs);
         log.addHandler(hnd);
-        final Thread thread = new Thread(
-            () -> {
-                final String property = System.getProperty(DataizedTest.DATAIZATION_LOG);
-                System.getProperties().setProperty(
-                    DataizedTest.DATAIZATION_LOG,
-                    String.valueOf(level)
-                );
-                final Phi phi = new PhiDec(Phi.Φ);
-                new Dataized(phi, log).take();
-                if (property != null) {
-                    System.getProperties().setProperty(DataizedTest.DATAIZATION_LOG, property);
-                } else {
-                    System.clearProperty(DataizedTest.DATAIZATION_LOG);
-                }
-            });
+        final Thread thread = new DataizedLoggerThread(log, 2);
         thread.start();
         thread.join();
         log.setLevel(before);
         log.removeHandler(hnd);
-        if (level == 1) {
-            MatcherAssert.assertThat(
-                "Number of log records should be 1 in case of short logs",
-                logs.size(),
-                Matchers.equalTo(1)
-            );
-        } else if (level == 2) {
-            MatcherAssert.assertThat(
-                "Number of log records should be greater than 1 in case of long logs",
-                logs.size(),
-                Matchers.greaterThan(1)
+        MatcherAssert.assertThat(
+            "Number of log records should be greater than 1 the in case of long logs",
+            logs.size(),
+            Matchers.greaterThan(1)
+        );
+    }
+
+    /**
+     * Thread that logs dataization process with specified log level.
+     * @since 1.0
+     */
+    private static class DataizedLoggerThread extends Thread {
+        /**
+         * Ctor.
+         *
+         * @param logger Logger.
+         * @param level Log level.
+         */
+        DataizedLoggerThread(final Logger logger, final int level) {
+            super(
+                () -> {
+                    final String property = System.getProperty(
+                        DataizedTest.MAX_DATAIZATION_LOG_PROPERTY
+                    );
+                    System.getProperties().setProperty(
+                        DataizedTest.MAX_DATAIZATION_LOG_PROPERTY,
+                        String.valueOf(level)
+                    );
+                    final Phi phi = new PhiDec(Phi.Φ);
+                    new Dataized(phi, logger).take();
+                    if (property != null) {
+                        System.getProperties().setProperty(
+                            DataizedTest.MAX_DATAIZATION_LOG_PROPERTY,
+                            property
+                        );
+                    } else {
+                        System.clearProperty(DataizedTest.MAX_DATAIZATION_LOG_PROPERTY);
+                    }
+                }
             );
         }
     }