From 85ce4c3c8c45dba7a1cff611c71d029602224cce Mon Sep 17 00:00:00 2001 From: Roman Korostinskiy <70313618+c71n93@users.noreply.github.com> Date: Tue, 5 Mar 2024 14:56:07 +0300 Subject: [PATCH] #2863 replace anonymous class by single implementation to reduce code duplicatoin --- .github/workflows/simian.yml | 2 +- .../test/java/org/eolang/DataizedTest.java | 92 ++++++------------- 2 files changed, 29 insertions(+), 65 deletions(-) diff --git a/.github/workflows/simian.yml b/.github/workflows/simian.yml index 2f1afb342c..6c2e2d85e2 100644 --- a/.github/workflows/simian.yml +++ b/.github/workflows/simian.yml @@ -24,4 +24,4 @@ jobs: - run: | wget --quiet http://public.yegor256.com/simian.jar -O /tmp/simian.jar - run: | - java -jar /tmp/simian.jar -threshold=25 -excludes=**/gen -excludes=**/it **/*.java + java -jar /tmp/simian.jar -threshold=16 -excludes=**/gen -excludes=**/it **/*.java diff --git a/eo-runtime/src/test/java/org/eolang/DataizedTest.java b/eo-runtime/src/test/java/org/eolang/DataizedTest.java index 543c129406..c940a9fc94 100644 --- a/eo-runtime/src/test/java/org/eolang/DataizedTest.java +++ b/eo-runtime/src/test/java/org/eolang/DataizedTest.java @@ -48,22 +48,7 @@ void logsCorrectly() { final Level before = log.getLevel(); log.setLevel(Level.ALL); final List logs = new LinkedList<>(); - final Handler hnd = new Handler() { - @Override - public void publish(final LogRecord record) { - logs.add(record); - } - - @Override - public void flush() { - throw new UnsupportedOperationException("#flush()"); - } - - @Override - public void close() throws SecurityException { - throw new UnsupportedOperationException("#close()"); - } - }; + final Handler hnd = new TestHandler(logs); log.addHandler(hnd); new Dataized(new Data.ToPhi(1L), log).take(); log.setLevel(before); @@ -83,22 +68,7 @@ void logsWhenException() { final Level before = log.getLevel(); log.setLevel(Level.ALL); final List logs = new LinkedList<>(); - final Handler hnd = new Handler() { - @Override - public void publish(final LogRecord record) { - logs.add(record); - } - - @Override - public void flush() { - throw new UnsupportedOperationException("#flush()"); - } - - @Override - public void close() throws SecurityException { - throw new UnsupportedOperationException("#close()"); - } - }; + final Handler hnd = new TestHandler(logs); log.addHandler(hnd); final Phi wrong = new PhIncorrect(Phi.Φ); IntStream.range(0, 5).forEach( @@ -125,22 +95,7 @@ void printsShortLogs() throws InterruptedException { final Level before = log.getLevel(); log.setLevel(Level.ALL); final List logs = new LinkedList<>(); - final Handler hnd = new Handler() { - @Override - public void publish(final LogRecord record) { - logs.add(record); - } - - @Override - public void flush() { - throw new UnsupportedOperationException("#flush()"); - } - - @Override - public void close() throws SecurityException { - throw new UnsupportedOperationException("#close()"); - } - }; + final Handler hnd = new TestHandler(logs); log.addHandler(hnd); final Thread thread = new Thread( () -> { @@ -170,22 +125,7 @@ void printsLongLogs() throws InterruptedException { final Level before = log.getLevel(); log.setLevel(Level.ALL); final List logs = new LinkedList<>(); - final Handler hnd = new Handler() { - @Override - public void publish(final LogRecord record) { - logs.add(record); - } - - @Override - public void flush() { - throw new UnsupportedOperationException("#flush()"); - } - - @Override - public void close() throws SecurityException { - throw new UnsupportedOperationException("#close()"); - } - }; + final Handler hnd = new TestHandler(logs); log.addHandler(hnd); final Thread thread = new Thread( () -> { @@ -261,4 +201,28 @@ public static class PhiDec extends PhDefault { } } + private static class TestHandler extends Handler { + final List logs; + + TestHandler(final List logs) { + this.logs = logs; + } + + @Override + public void publish(final LogRecord record) { + logs.add(record); + } + + @Override + public void flush() { + throw new UnsupportedOperationException("#flush()"); + } + + @Override + public void close() throws SecurityException { + throw new UnsupportedOperationException("#close()"); + } + + } + }