Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some classes have virtual functions but not virtual constructors, causing -Werror=non-virtual-dtor #105

Open
Splanzar opened this issue Apr 28, 2021 · 0 comments

Comments

@Splanzar
Copy link

We have -Wnon-virtual-dtor -Wall -Werror in our g++ command which compiles with mFast headers. We are getting below issues:

..../mfast/instructions/template_instruction.h:50:7: error: ‘class mfast::template_instruction_ex<template_shse::hkSnapshot_cref>’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]

We need to find out all the classes with similar issues and add virtual destructors to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant