Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

support for other platforms #15

Closed
hohwille opened this issue Oct 9, 2014 · 10 comments
Closed

support for other platforms #15

hohwille opened this issue Oct 9, 2014 · 10 comments

Comments

@hohwille
Copy link
Member

hohwille commented Oct 9, 2014

It would be nice to write unix/mac scripts for the bat files that we currently have for windows support. Contributions are very welcome.

@henning-cg
Copy link
Contributor

I have started a basic port of the environment setup and workspace creation scripts at https://github.com/henning-cg/oasp4j-ide/tree/unix_support.

Right now, it only setups Maven and the necessary variables to get the eclipse config generator running.

Right now I am following the same structure, more or less, than the windows version, so future changes are more portable between the two.

Instead of a console.bat there is a env.sh, which one should source from a bash prompt to set up the necessary variables.

Any further input is very welcome!

@hohwille hohwille added this to the release:1.3.2 milestone Apr 30, 2015
@hohwille
Copy link
Member Author

Cool! @henning-cg Thanks for your input. 👍
We will integrate this into the next release (Probably we should rename to 1.4.0 then).

@hohwille
Copy link
Member Author

Would you mind to merge this onto develop and create a pull-request for it?

@hohwille
Copy link
Member Author

Instead of a console.bat there is a env.sh, which one should source from a bash prompt to set up the necessary variables.

IMHO there would be no need for setting OASP_PROJECT_HOME externally.
You could use "dirname $0" to figure out the location relative from the script.
We could then also port the IDEenv script.

@henning-cg
Copy link
Contributor

"dirname $0" does not work if you source a script, ie. execute it directly in the running shell, as $0 would point to the executable of the running shell.

I think there is value in determining the absolute path to the active project's folder, as it makes writing other scripts easier, as long as you have sourced env.sh beforehand.

@henning-cg
Copy link
Contributor

Created pull request #48

@hohwille
Copy link
Member Author

"dirname $0" does not work if you source a script...

I am aware, but I was not talking about env.sh but about environment-project.sh.
Maybe I will find some time on the long weekend to give it a try on my linux machine and find a solution.
Thank you so much for your input!

@henning-cg
Copy link
Contributor

Ah, I see.

Well, as I saw it, env.sh is the main starting point, and every other script depends on having sourced env.sh earlier, including environment-project.sh, but it is true that the other scripts are meant to be called directly, and not sourced, and therefore could simply use $0.

hohwille added a commit that referenced this issue May 3, 2015
hohwille added a commit that referenced this issue May 3, 2015
hohwille added a commit that referenced this issue May 3, 2015
hohwille added a commit that referenced this issue May 3, 2015
hohwille added a commit that referenced this issue May 3, 2015
hohwille added a commit that referenced this issue May 3, 2015
@henning-cg
Copy link
Contributor

Should we close this issue and create another one for adding a platform-flag to the workspace configuration?

hohwille added a commit that referenced this issue May 21, 2015
#15: More fixes for unix support
@hohwille hohwille mentioned this issue May 21, 2015
2 tasks
@hohwille
Copy link
Member Author

Created #53 and #54. This one is done now.

hohwille added a commit that referenced this issue Nov 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants