Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink and extend the CLI output on interactive zkApp deployment. #633

Open
shimkiv opened this issue Apr 30, 2024 · 0 comments
Open

Rethink and extend the CLI output on interactive zkApp deployment. #633

shimkiv opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@shimkiv
Copy link
Member

shimkiv commented Apr 30, 2024

During the work on #631

@MartinMinkov raised:

Open question: Would it be helpful to list the dependencies for which a Smart Contract needs to be deployed? For example, if it depends on a ZkProgram to be compiled in the same project as well.

Some reasons I can see it being nice to have (mostly from a user-friendly perspective):

  1. Transparency in what you are deploying. A compiled list of dependencies could be nice in the deployment output.
  2. Has some educational value for newcomers seeing their dependencies as part of the deployment output

Some reasons not to have it:

  1. Could lead to some clutter that isn't necessary and has some output overload

What do you think?

And @ymekuria replied:

@MartinMinkov I think it is a good idea to list all the dependancies somewhere, but as @shimkiv mentioned it will necessitate more discussion and thought to do it well. We will have to think about how to display the dependancies in a intuitive way, whether or not we should store the dependency tree in the config, and what the best data structure to do so etc etc. All that said, I like the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant