-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for StoreWordLeft
#2318
base: master
Are you sure you want to change the base?
Conversation
If the instruction wasn't implemented incorrectly, it means we never had it in the past. I'm running the o1VM on the real infra to check this assumption. |
Without checking your changes, I think the previous implementation is correct. Running on your branch gives me this exit code:
|
On input
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the failing e2e test
This used to fail before as well, as tracked here -> #2075 |
Demo halts, making the PR a draft until solved |
Fixes the interpreter to behave like Cannon.