Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ELSA Multitenant #59

Open
matthewsilver opened this issue Dec 17, 2020 · 6 comments
Open

Make ELSA Multitenant #59

matthewsilver opened this issue Dec 17, 2020 · 6 comments

Comments

@matthewsilver
Copy link
Collaborator

Enable multiple systems operating on the same ELSA instance (for Google docs and LPaaS). Currently only one organization can operate on a given ELSA instance

@matthewsilver
Copy link
Collaborator Author

@liquidsteves @nyccto-rapicastillo @jisaf
Looking into this more, I'm not sure whether this is worth the overhead. We would need to manage users or namespaces and permission them appropriately, so anytime someone new wants to use ELSA, we'd need to create a new user and keep track internally of users in some database so that we can oversee user ids, permissions, and resource allocation/separation. On the other hand, if we have the Docker image available for people to pull and they run their own container, we don't need to worry about this (and can fill out the AWS setup section to fill the gap for infrastructure setup). Thoughts?

@liquidsteves
Copy link
Collaborator

Best to keep things as simple as possible. Less work is good.

@jisaf
Copy link
Contributor

jisaf commented Mar 7, 2021

This logic makes sense at this point.

Out of curiosity, would turning this serverless and moving to lambda functions make spinning up new instances any easier?

Alternatively, what about passing a key in with each request that simply uses a different config for translation api keys. So we just store different config files or env keys as a half way solution. That was all processing is done on a single tenant, but billing is managed based on the key sent in (if, in the future, someone can dictate what translation service is used then possibly just allow for multiple billing keys for each service in the same way?)

@jisaf
Copy link
Contributor

jisaf commented Mar 7, 2021

Also, you are a hero for looking into this!

@matthewsilver
Copy link
Collaborator Author

Serverless/lambda is an interesting idea. I haven't worked with it, but it might be a plus for people who don't want to maintain their own EC2 instance (although lambda does require some AWS knowledge with credentials).

With cost allocation, I'd be concerned that a central org. would need to be in charge of billing, and that's a lot for one team to keep track of.

Btw, I'm turning notifications on for issue comments, so I'll respond more quickly in the future.

@liquidsteves
Copy link
Collaborator

Turning on and off the right notifications is getting to be an important life skill. So hard to get notified about the right things without being spammed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants