Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for wordpress, google docs import_export #53

Open
liquidsteves opened this issue Nov 21, 2020 · 5 comments
Open

Write unit tests for wordpress, google docs import_export #53

liquidsteves opened this issue Nov 21, 2020 · 5 comments

Comments

@liquidsteves
Copy link
Collaborator

No description provided.

@liquidsteves
Copy link
Collaborator Author

Shannon wrote a ton of tests for the google translate translation_service. We should imitate her tests.

@matthewsilver
Copy link
Collaborator

@liquidsteves I took a quick look at this, based on how I structured the import/export docs code it might be hard to make unit tests without serious refactoring/modularizing. But if you see any low-hanging fruit let me know.

@matthewsilver
Copy link
Collaborator

Could also do integration tests where we have a designated source and destination folder in Google drive and do a simple caps translation or something, but not sure who would be in charge of the Google drive account. Could mock the responses, but that gets us back to unit testing which has the current code limitations I commented above.

@liquidsteves
Copy link
Collaborator Author

Refactoring and modularizing would be good if you have the energy for it, but it's not urgent.

@liquidsteves
Copy link
Collaborator Author

Integration tests are hard to maintain so I'd rather not build them until we have a clear need. (Eg if several new people were working on the code and important things kept breaking.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants