Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more focus event issue after reloading appModules #17322

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Oct 24, 2024

Link to issue number:

Fixes #17323

Summary of the issue:

After a reload of plugins (NVDA+control+f3), focus events do not report the new focus as expected.

During focus event, NVDA tests which tree interceptors are alive or not to clean up those which are dead. In this test, for MSHTML, NVDA looks at root.appModule.appName, root being the root object associated to the virtual MSHTML buffer.

However, root.appModule may be None after plugins are reloaded.

Description of user facing changes

After plugins are reloaded while a browseable message is opened, the focus will no longer fail to be reported.

Description of development approach

Fixed the logic for MSHTML

Testing strategy:

Tested STR in #17323.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79 CyrilleB79 marked this pull request as ready for review October 24, 2024 15:32
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner October 24, 2024 15:32
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 28, 2024
@seanbudd
Copy link
Member

seanbudd commented Nov 4, 2024

I merged #17334 from @LeonarddeR. can you resolve conflicts?

@CyrilleB79
Copy link
Collaborator Author

@seanbudd, I have upmerged from latest master.

The changes that I had made in source/keyboardHandler.py have been taken by @LeonarddeR in #17334 so this file is not part of this PR anymore.

@CyrilleB79
Copy link
Collaborator Author

Also updated the initial description consequently.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focused objects not reported after a plugins reload
2 participants