No more focus event issue after reloading appModules #17322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17323
Summary of the issue:
After a reload of plugins (
NVDA+control+f3
), focus events do not report the new focus as expected.During focus event, NVDA tests which tree interceptors are alive or not to clean up those which are dead. In this test, for MSHTML, NVDA looks at
root.appModule.appName
,root
being the root object associated to the virtual MSHTML buffer.However,
root.appModule
may beNone
after plugins are reloaded.Description of user facing changes
After plugins are reloaded while a browseable message is opened, the focus will no longer fail to be reported.
Description of development approach
Fixed the logic for MSHTML
Testing strategy:
Tested STR in #17323.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary