Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document silent uninstallation of NVDA in the user guide #17203

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Document silent uninstallation of NVDA in the user guide #17203

merged 4 commits into from
Sep 30, 2024

Conversation

SaschaCowley
Copy link
Member

@SaschaCowley SaschaCowley commented Sep 23, 2024 •
edited
Loading

Link to issue number:

Closes #16966

Summary of the issue:

While it is possible to silently uninstall NVDA from the command line, this option is not documented anywhere.

Description of user facing changes

Added notes on command line uninstallation of NVDA to the "Command Line Options" section of the user guide.

Description of development approach

Read the NSIS documentation to ensure there wasn't any nuance I was missing.

Testing strategy:

Tested silently uninstalling NVDA.

Known issues with pull request:

Users may find it confusing that the installer takes Unix-style options but the uninstaller takes DOS-style options.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley requested a review from a team as a code owner September 23, 2024 06:58
@SaschaCowley SaschaCowley linked an issue Sep 23, 2024 that may be closed by this pull request
Document command line uninstallation of NVDA in the user guide #16966
Closed
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Sep 24, 2024
XLTechie
XLTechie reviewed Sep 25, 2024
View reviewed changes
user_docs/en/userGuide.md Outdated Show resolved Hide resolved
XLTechie
XLTechie reviewed Sep 25, 2024
View reviewed changes
user_docs/en/userGuide.md Outdated Show resolved Hide resolved
Qchristensen
Qchristensen approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@SaschaCowley SaschaCowley merged commit 25cfe97 into master Sep 30, 2024
4 checks passed
@SaschaCowley SaschaCowley deleted the i16966 branch September 30, 2024 05:12
@github-actions github-actions bot added this to the 2025.1 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XLTechie XLTechie XLTechie left review comments

@CyrilleB79 CyrilleB79 CyrilleB79 left review comments

@seanbudd seanbudd seanbudd approved these changes

@Qchristensen Qchristensen Qchristensen approved these changes

Assignees
No one assigned
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.

Document command line uninstallation of NVDA in the user guide
5 participants
@SaschaCowley @seanbudd @XLTechie @Qchristensen @CyrilleB79