Fix braille breakage when activating say all with a config profile enabled

[LeonarddeR]

Link to issue number:

Fixed #17163

Summary of the issue:

When you have a config profile attached to say all and activate a config profile, braille is broken until you move out and into the document control.

Description of user facing changes

Braille follows along properly.

Description of development approach

The problem was that in the braille handler, self._tether was set to auto when it was configured to auto. However self._tether should only contain the internal tether state, focus or review. Therefore if it is configured as auto, do not override the internal tether state of the braille handler.

Testing strategy:

Tested str from #17163

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary

[seanbudd]

Do you know when this regression was introduced? Should it go to 2024.4 beta?

[LeonarddeR]

I'm pretty sure it was there for a long time, I think I tested back to 2023.1 or so and the issue was there as well.