Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popup menu item reading on Thunderbird #17130

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Fix popup menu item reading on Thunderbird #17130

merged 3 commits into from
Sep 15, 2024

Conversation

thgcode
Copy link
Contributor

@thgcode thgcode commented Sep 7, 2024 •
edited
Loading

Link to issue number:

closes #4708 .

Summary of the issue:

When the user finds text on Thunderbird by pressing CONTROL+K, searching the text and activating one of the links, NVDA speaks only "section".

Description of user facing changes

NVDA will speak the popup menu item name correctly.

Description of development approach

Added a check if the object 's name is empty, and is of the "div" tag and has a class of "popup-menuitem", NVDA replaces its name with the name of its child.

Testing strategy:

Performed manual tests with Thunderbird 128.2.0 and 102.6.0.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@thgcode thgcode mentioned this pull request Sep 7, 2024
Closed
@seanbudd
Copy link
Member

seanbudd commented Sep 9, 2024

is this ready for review?

@thgcode
Fix popup menu item reading on Thunderbird (nvaccess#4708)
66ddcde 
Summary of the issue:
When the user finds text on Thunderbird by pressing CONTROL+K, searching the text and activating one of the links, NVDA speaks only "section".

Description of user facing changes
NVDA will speak the popup menu item name correctly.

Description of developer facing changes
None.

Description of development approach
Added a check if the object 's name is empty, and is of the "div" tag and has a class of "popup-menuitem", NVDA replaces its name with the name of its child.

Testing strategy:
Performed a manual test with Thunderbird.
@thgcode
Add changelog entry
075006d
@thgcode thgcode marked this pull request as ready for review September 9, 2024 21:24
@thgcode thgcode requested a review from a team as a code owner September 9, 2024 21:24
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Sep 10, 2024
seanbudd
seanbudd reviewed Sep 10, 2024
View reviewed changes
source/appModules/thunderbird.py Outdated Show resolved Hide resolved
source/appModules/thunderbird.py Outdated Show resolved Hide resolved
user_docs/en/changes.md Outdated Show resolved Hide resolved
@seanbudd
Copy link
Member

Thanks for your contribution @thgcode

@seanbudd seanbudd merged commit ac1f3a4 into nvaccess:master Sep 15, 2024
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees
No one assigned
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.

find messages in thunderbird.
2 participants
@thgcode @seanbudd