Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated translated developerGuide, or move to Crowdin (was: remove outdated files) #13333

Open
CyrilleB79 opened this issue Feb 12, 2022 · 24 comments · Fixed by #15939
Open
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. component/documentation needs-triage p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone

Comments

@CyrilleB79
Copy link
Collaborator

CyrilleB79 commented Feb 12, 2022

Issue opened after discussion in #13119 (comment) and #13119 (comment) regarding translated developer's guides.

Steps to reproduce:

List the file names in all the language subfolders of user_docs folder.

Actual behavior:

The most common (and expected files are: changes.html/.t2t, keyCommands.html/.t2t, styles.css, userGuide.html/.t2t.

Still remaining - to be either removed or moved to crowdin:
developerGuide.html/.md in de and pt_BR folders
Last commits: Fri Aug 3 2012 (de) and Tue Aug 9 2011 (pt_BR)

Removed:

  1. locale.t2tconf files are present for ar, fa and he languages to manage right to left text direction and arabic numbers.
  2. locale.t2tconf in ca (Catalan) folder
    Last commit: Wed Aug 20 21:42:40 2014 +0100
  3. hu\chapter0.t2tinc
    Last commit: Wed Mar 20 2013
  4. th\key commands.txt
    Last commit: Sun Dec 14 2008

Expected behavior:

The files listed in 1. and 2. are expected. The files listed in the other points were not expected. The question arises of removing them for the following reasons:

  • Files listed in 4. and 6. are very old and it is expected that such files are updated regularly (dev guide and key commands). It should be investigated if these files are still of any use for their respective community (de, pt_BR and th) since they are probably far from up-to-date.
    Note that "th/key commands.txt" is not even opened when setting NVDA in Thai and clicking the "Key commands" item in the "Help" menu; English key commands html file is opened instead. Either this file should be renamed "keyCommands.txt" to be accessed through the menu or some dead code could probably be removed from getDocFilePath in file documentationUtils.py.
  • ca\locale.t2tconf (3.): I wonder why Catalan needs a specific processing with respect to other latin languages. Either other languages should benefit from what has been done for Catalan, or this specific processing for Catalan is not needed anymore; to be investigated.
  • Point 3.: hu user guide adds additional specific content. It should be stated if local teams are still allowed to include such specific content with respect to the standard user guidd. This decision can be made when the new translation framework is set up.

System configuration

NVDA installed/portable/running from source:

N/A

NVDA version:

2021.3.1

Windows version:

N/A

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

N/A

Have you tried any other versions of NVDA? If so, please report their behaviors.

N/A

If NVDA add-ons are disabled, is your problem still occurring?

N/A

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A

Cc @bdorer, @mhameed who have committed on these files.
Also wanted to cc David Parduhn, Rene Linke and Peter Vagne, but I do not have their GitHub user name (if they have one).

@tiago-casal
Copy link

Hello! The pt_BR/developerGuide.t2t translation is being updated, but it will take a while to get ready.

@CyrilleB79
Copy link
Collaborator Author

Hello! The pt_BR/developerGuide.t2t translation is being updated, but it will take a while to get ready.

Thanks for your feedback @tiago-casal. Could you tell a bit more on the pt_BR dev guide:

  • Who is translating this doc? Yourself? With others?
  • Is there a more recent version somewhere else than the one bundled in NVDA?
  • Is the pt_BR dev guide used in the Brazilian dev community or in the Portuguese one? If yes, which version?
  • How do translator(s) manage the updates in the source (English) dev guide? Is the translator translating a specific commit of this doc?

I think all this information is needed to show that this translation is a living project.

@cary-rowen

This comment was marked as off-topic.

@CyrilleB79

This comment was marked as off-topic.

@tiago-casal
Copy link

Hello! The pt_BR/developerGuide.t2t translation is being updated, but it will take a while to get ready.

Thanks for your feedback @tiago-casal. Could you tell a bit more on the pt_BR dev guide:

  • Who is translating this doc? Yourself? With others?
  • Is there a more recent version somewhere else than the one bundled in NVDA?
  • Is the pt_BR dev guide used in the Brazilian dev community or in the Portuguese one? If yes, which version?
  • How do translator(s) manage the updates in the source (English) dev guide? Is the translator translating a specific commit of this doc?

I think all this information is needed to show that this translation is a living project.

Hello @CyrilleB79!

I'm part of the NVDA Brazilian Portuguese translation team, I'm working on updating the developerGuide.t2t file; in the team, everyone contributes to the work of others, whether translating or revising; everything that is documentation is interesting to be translated into the native language, there are users who want to start contributing and only speak the native language, translated document is the first step.

The update is currently being based on the English file that is in the sources of NVDA 2021.3.1; this probably won't end before the release of NVDA 2022.1, so when beta versions of NVDA 2022.1 are released we will use the latest version file.

It's difficult to identify the changes due to the lack of the same mechanism (scripts) used to create a differences file in the translation repository, I ended up doing it manually (I have a Linux distribution installed on my PC and I use diff).

When it was finished, I would send a pull request attaching the file for replacement in the sources, now that the outdated files are being deleted, I'll need to find a place to make them available, as it doesn't come in the NVDA installer; a site suggestion that could be thought of so that such files are available even without coming in the installer, would be at (what do you think of this?): https://www.nvaccess.org/files/nvda/releases/stable/documentation/

The NVDA European Portuguese translation team also has a translated version of developerGuide.t2t, which is in the translation repository, it's also outdated: https://subversion.assembla.com/svn/screenReaderTranslations/pt_PT/developerGuide.t2t

Thankful for your attention!

@josephsl
Copy link
Collaborator

josephsl commented Feb 14, 2022 via email

@tiago-casal
Copy link

Hi, the thing is, developer guide is not really meant to be translated, although I understand the need for a translated version of this document for language communities. I propose that language communities host translated versions of developer documentation on their websites or a place where people speaking the said language can gather. Thanks.

Thanks @josephsl! I understand, however, the lack of a centralized place for making materials available from NVDA with optional translation, makes things fragmented, there are teams that don't even have their own website, making it available on the NVDA Community Add-ons website I don't know if it would be an appropriate alternative, this would unstandardize the website.

@josephsl
Copy link
Collaborator

josephsl commented Feb 14, 2022 via email

@tiago-casal
Copy link

Hi, until recently the community add-ons website was home to add-on development guide, but the guide was moved to GitHub so it can be kept updated as NVDA development progresses. As a compromise, I think it would be best to revive the language portal page from NV Access site where we have links to language communities. Thanks.

Hi, it would really help if the NVDA Add-on Development Guide were restored on the NVDA Community Add-ons website, and additionally, the developerGuide.t2t in question was included, so it would be much more practical to translate both when each team wants. Grateful!

@josephsl
Copy link
Collaborator

josephsl commented Feb 14, 2022 via email

@CyrilleB79
Copy link
Collaborator Author

When it was finished, I would send a pull request attaching the file for replacement in the sources, now that the outdated files are being deleted, I'll need to find a place to make them available, as it doesn't come in the NVDA installer;

Please note that the pt_BR dev guide is not deleted from NVDA's codebase for now. In this PR, I was asking for unmaintained files. However since you explain that there is an active work on this guide's translation, I do not consider it anymore as an unmaintained file.

Then if maintained translated developer guide should be removed from NVDA's core and put elsewhere will be the decision of NVAccess at the end. I suggest not to do anything on this point before they decide something; maybe this decision will also be part of the new translation framework.

The NVDA European Portuguese translation team also has a translated version of developerGuide.t2t, which is in the translation repository, it's also outdated: https://subversion.assembla.com/svn/screenReaderTranslations/pt_PT/developerGuide.t2t

Thanks for the information. I did not know of it.

Clearly there should be a clarification on if, where and how dev guides (NVDA and add-on) should be translated. However it should not be discussed in this little issue IMO.
More specifically, let's stop discussing add-on dev guide translation here since it is not the place at all.
Thanks.

@tiago-casal
Copy link

Please note that the pt_BR dev guide is not deleted from NVDA's codebase for now. In this PR, I was asking for unmaintained files. However since you explain that there is an active work on this guide's translation, I do not consider it anymore as an unmaintained file.

Thank you very much!

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority good first issue github features these at https://github.com/nvaccess/nvda/contribute triaged Has been triaged, issue is waiting for implementation. component/documentation labels May 17, 2022
@seanbudd
Copy link
Member

Note that now locale.t2tconf is supported and expected, these files should no longer be removed (#8856 #14546)

@seanbudd
Copy link
Member

user_docs\hu\chapter0.t2tinc is a dependency of hungarian userGuide so it should not be removed either, instead migrated into the userGuide file properly

@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Dec 22, 2023
@seanbudd seanbudd modified the milestones: 2024.2, 2024.1 Dec 22, 2023
@seanbudd seanbudd reopened this Dec 22, 2023
@seanbudd
Copy link
Member

seanbudd commented Dec 22, 2023

user_docs\hu\chapter0.t2tinc and the developer guides still remain to be considered removed

@seanbudd
Copy link
Member

user_docs\hu\chapter0.t2tinc will be removed when we migrate from t2t to markdown as a source of truth. it is currently bundled/injected into the markdown file user_docs\hu\userGuide.md automatically.

So the only remaining question is whether we include the developerGuide optionally in the new translation system, or remove them

@Adriani90
Copy link
Collaborator

If the developer guide should ideally be translated, I would post a message to the translations mailing list and ask if people intend to work on it. Maybe explaining also how to add the developer guide to the respective language. I feel like many translators are even not really aware that this is possible and how. If there is no positive resonance about this, then I agree the files can be removed.

@seanbudd
Copy link
Member

Given that the user guide and changes document will require a lot of work from translators in the 2024.1 release, I don't think we will consider including the dev guide until 2024.2

@seanbudd seanbudd modified the milestones: 2024.1, 2024.2 Jan 17, 2024
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
Closes nvaccess#13333

Summary of the issue:
To aid with converting to markdown, fixing txt2tags syntax issues will ensure the conversion works as expected.
Note that not all syntax issues are fixed, however this PR intends to catch easy fixes that can be fixed with regex.
This may result in bad syntax in the markdown files, however these are syntax issues in the current documentation so conversion is unlikely to be a step in a worse direction.

Description of user facing changes
None

Description of development approach
Regex groups:

([^`])`([^`]) replaced with $1``$2
^ (  )*- to detect lists indented by an odd number of spaces
Unmaintained files in user_docs have been removed
@Nael-Sayegh
Copy link
Contributor

Hello @CyrilleB79 ,
Is this ticket still active?
I could take care of cleaning the files based on your various comments.

@CyrilleB79
Copy link
Collaborator Author

@Nael-Sayegh could you summarize what needs to be cleaned?
A quick look at the discussion let me think that only the dev guide topic is still relevant.

But according to #13333 (comment) and the linked discussions, it is not sure that the dev guide will be removed.

@Nael-Sayegh
Copy link
Contributor

@CyrilleB79 Based on this response from @seanbudd in this comment, I understood that there was consideration of deleting the developer guide. If that's not the case, I conclude that there are no files left to delete. But then, why does this issue remain open?

@CyrilleB79
Copy link
Collaborator Author

But in #13333 (comment) that is more recent, it seems that inclusion of the dev guide may be considered for 2024.2, or maybe 2024.3 actually since the transition to the new framework for the Change log and User Guide have been shifted to 2024.2.

But the decision to include it or not does not seem to be definitively made. Thus I'd suggest to revisit this issue and decide for the dev guide after the Change log and the User Guide are migrated to CrowdIn.

@seanbudd seanbudd modified the milestones: 2024.2, 2024.3 Apr 14, 2024
@seanbudd seanbudd added blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. needs-triage and removed good first issue github features these at https://github.com/nvaccess/nvda/contribute triaged Has been triaged, issue is waiting for implementation. labels May 24, 2024
@seanbudd seanbudd changed the title Remove unmaintained files in user_docs folder Remove outdated translated developerGuide, or move to Crowdin (was: remove outdated files) May 24, 2024
@seanbudd
Copy link
Member

seanbudd commented May 30, 2024

In #16627 (comment) @Adriani90 wrote:

If this is part of the developer guide, then in my view it becomes even more relevant to deploy the developer guide via SVN or Crowdin for tranlsation to every language, so #13333 should definitely not cause the developer guide to be removed.

To be clear, this issue is about determining if the devGuide should be translatable. If not, the outdated german and portugese developer guides are under consideration for removal, not the base devGuide.
I'm not sure if #16627 should affect this decision.
The alternative to #16627 is to migrate the content into a "translating guide" or keep it "projectDocs" like other documentation.
It is unlikely "projectDocs" will be translated any time soon, however a translating guide could be translated independently.

For translators, being able to understand English is a must.
While I understand that translating the guides for translating may make translating easier, I don't see it as impacting this issue.
I don't see how translating the translating guides has a higher impact than translating the developer Guide as-is.
Add-on developers do not need to understand english, so lowering the barrier for them is of higher importance than translators, which need to understand english.

@seanbudd seanbudd modified the milestones: 2024.3, 2024.4 Jun 26, 2024
@seanbudd seanbudd modified the milestones: 2024.4, 2025.1 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. component/documentation needs-triage p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants