Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The local provider does not perform font metric optimization #171

Open
dungsil opened this issue Jun 4, 2024 · 2 comments
Open

The local provider does not perform font metric optimization #171

dungsil opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working provider

Comments

@dungsil
Copy link

dungsil commented Jun 4, 2024

I'm not sure if this is intended, but it appears that the fonts available through the Local provider are not being optimised.

In the screenshot, Inter from google is displayed as ‘Fallback font: Inter’, but Pretendard from local is not.

image

@dosubot dosubot bot added the provider label Jun 4, 2024
dungsil added a commit to dungsil/issues that referenced this issue Jun 4, 2024
@dungsil
Copy link
Author

dungsil commented Jun 4, 2024

Copy link

dosubot bot commented Jun 4, 2024

Hello, @dungsil! I'm here to assist you with any bugs, questions, or becoming a contributor. Let's tackle this together! 🤖

The local provider does not perform font metric optimization because the current implementation does not support reading font metrics. This is indicated by a TODO comment in the code:

// TODO: support reading font metrics

This means that while the local provider can register and resolve font files, it does not have the capability to optimize font metrics, which is why local fonts like Pretendard are not optimized. In contrast, fonts from Google, like Inter, are likely optimized because the Google provider includes font metric optimization [1][2].

To continue talking to Dosu, mention @dosu.

@danielroe danielroe added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider
Projects
None yet
Development

No branches or pull requests

2 participants