Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use legacy property publicPath for the assets url. #1303

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Aug 31, 2024

πŸ”— Linked issue

Fixes: #635

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In nuxt 2 the option to set the cdn url is publicPath.
https://v2.nuxt.com/docs/configuration-glossary/configuration-build/

The app.cdnURL is not used directly and must be set to publicPath.

Also, currently NUXT_APP_CDN_URL is not supported and must be set to app.cdnURL.

export default defineNuxtConfig({
  app: {
    cdnURL: process.env.NUXT_APP_CDN_URL
  }
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 66feedf into main Oct 15, 2024
61 checks passed
@danielroe danielroe deleted the fix/assets-url branch October 15, 2024 13:29
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUXT_APP_CDN_URL ignored when serving images
2 participants