Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Nuxt 4 #3105

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: support Nuxt 4 #3105

merged 2 commits into from
Sep 17, 2024

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Technically all this does is remove the version checks and adds a test and fixture that uses future: { compatibilityVersion: 4 } to test Nuxt 4 usage. I think it should be possible to merge this into the v8 branch as well without issue.

I want to address #2983 in a separate (breaking) PR, so that i18n files are no longer resolved relative to srcDir.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Sep 16, 2024
kazupon
kazupon approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Good job!
LGTM!

@kazupon kazupon merged commit 73f6b99 into nuxt-modules:main Sep 17, 2024
8 checks passed
BobbieGoede added a commit to BobbieGoede/i18n that referenced this pull request Sep 17, 2024
@BobbieGoede
feat: support Nuxt 4 (nuxt-modules#3105)
652ab4f 
* test: add test and fixture using `compatibilityVersion: 4`

* fix: remove nuxt version checks
BobbieGoede added a commit that referenced this pull request Sep 17, 2024
@BobbieGoede
feat: support Nuxt 4 (#3105)
5ba983a 
* test: add test and fixture using `compatibilityVersion: 4`

* fix: remove nuxt version checks
@KTrain5169 KTrain5169 mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees

@BobbieGoede BobbieGoede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobbieGoede @kazupon