Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass problem details when discovery service returns them #3476

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

woutslakhorst
Copy link
Member

@woutslakhorst woutslakhorst commented Oct 9, 2024

fixes #3471

when the discovery server returns problem details, the client will try to parse. If successful, it'll pass on the error.

Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the change, but it doesn't fix the issue

discovery/api/server/client/http.go Outdated Show resolved Hide resolved
@woutslakhorst
Copy link
Member Author

I'm approving the change, but it doesn't fix the issue

The title of the issue was wrong. The goal was to return the error description at the server to the client and beyond. Not create specific error titles.

@woutslakhorst woutslakhorst merged commit 3c758a1 into master Oct 14, 2024
9 checks passed
@woutslakhorst woutslakhorst deleted the feature/3471_discovery_error_return branch October 14, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass error details from discovery server to client and to user.
2 participants