Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: log module name with IRMA log entries #1268

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Jul 17, 2022

Suggested change in irmago: privacybydesign/irmago#232

Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if we configure our logger to do JSON, then this logger will still do text?

@reinkrul
Copy link
Member Author

reinkrul commented Jul 27, 2022

But if we configure our logger to do JSON, then this logger will still do text?

No it will output as JSON: the JSONFormatter is set on the StandardLogger before the auth module is initialized, and this code copies the StandardLogger and wraps the Formatter (text or JSON) with a decorator that adds a field. The wrapped formatter will simply be the JSON formatter.

@reinkrul reinkrul merged commit d5e1875 into master Jul 28, 2022
@reinkrul reinkrul deleted the auth/irma-log-module branch July 28, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants