Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically scan for vulnerabilities on all supported release branches #3522

Closed
gerardsn opened this issue Oct 28, 2024 · 2 comments
Closed

Comments

@gerardsn
Copy link
Member

gerardsn commented Oct 28, 2024

We currently scan for vulnerabilities using CodeQL and govulncheck on the master and V* branches when a PR is opened/merged into these branches.

We should periodically scan for vulnerabilities on the same branches (or at least supported versions). I can't find a reliable way to schedule github actions for other branches because:

  • each branch requires its own github action file since you manually need to specify the branch if it is not the main branch. using a matrix for branches in actions/checkout allows using 1 file. This means we need to manually add a new action for every released minor version.
  • schedules are automatically deactivated after 60 days of inactivity on the repo. This is probably fine, but the schedule is not automatically reactivated if the repo has new activity.
  • schedules are deactivated if the user that made the last change to the 'cron' is removed from the organization. To reactivate the schedule, a change should be made to the 'cron' schedule (a change to the Github action file is insufficient).
  • schedule outcomes are only sent to the user that last modified the 'cron' value

So the main concern is: scheduled actions are easily deactivated without any warning, and it is hard to (re-)activate them.

@gerardsn
Copy link
Member Author

CodeQL is now scheduled to run twice per week

@gerardsn
Copy link
Member Author

gerardsn commented Nov 5, 2024

remaining concerns are limitations of the ecosystem and are accepted as is.

@gerardsn gerardsn closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant