Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCR: EmployeeCredential not in Nuts JSON-LD context #3176

Open
reinkrul opened this issue Jun 8, 2024 · 3 comments
Open

VCR: EmployeeCredential not in Nuts JSON-LD context #3176

reinkrul opened this issue Jun 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@reinkrul
Copy link
Member

reinkrul commented Jun 8, 2024

The newly introduced EmployeeCredential is not in the Nuts JSON-LD context. Meaning, they can't be issued through the API (we have client-side validation there) and if someone still manages to issue it in JSON-LD format (we use JWT), the fields (name, role, identifier) won't be protected by the signature.

@reinkrul reinkrul added bug Something isn't working rc issues for release candidate labels Jun 8, 2024
@woutslakhorst woutslakhorst added this to the V6 milestone Jul 9, 2024
@woutslakhorst
Copy link
Member

woutslakhorst commented Jul 9, 2024

is this still correct? We can now pass holder credentials with the request-service-access-token flow. The existing context also contains a NutsEmployeeCredential.

This concerns the OpenID4VP user flow where the Nuts node is acting as user wallet. Since we're not going to be a user wallet, removing the rc label.

@woutslakhorst woutslakhorst removed the rc issues for release candidate label Jul 9, 2024
@reinkrul
Copy link
Member Author

This also applies when performing the service-to-service flow, in which the caller wants to provide employee details. Although the v5 NutsEmpoyeeCredential could be used for that?

@woutslakhorst woutslakhorst removed this from the V6 milestone Sep 12, 2024
@woutslakhorst
Copy link
Member

The NutsEmpoyeeCredential can cover any need for user claims (using schema.org namespace). Do we still need this other one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants