Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2: make access token lifetime configurable #2956

Open
reinkrul opened this issue Mar 21, 2024 · 3 comments
Open

OAuth2: make access token lifetime configurable #2956

reinkrul opened this issue Mar 21, 2024 · 3 comments

Comments

@reinkrul
Copy link
Member

This is now hardcoded for 15 minutes, should be configurable. Note that we chose to hide the existing config flag in the auth module, since it is v5-specific. If we decide to re-use it for the IAM APIs, we need to un-hide it.

@m-rit
Copy link

m-rit commented Jun 1, 2024

Hi @reinkrul, can I raise a PR with enhancements for this issue if no one is assigned yet? I am looking to contribute to did based projects and this project looks quite interesting !

@reinkrul
Copy link
Member Author

reinkrul commented Jun 2, 2024

Hi @m-rit, thank you for your interest. I don't think this particular issue is interesting to work on if you want to learn about DIDs and contribute to their development (since it's got little to do with DIDs). But, we have another repo that's specifically meant for parsing DIDs, which has a issue which might be more interesting for you to solve: nuts-foundation/go-did#113

@gerardsn
Copy link
Member

gerardsn commented Nov 5, 2024

The lifetime might be related to the use-case. In that case it could be added to the policy definition file.

We make some assumptions about the lifetime of access tokens in storage. These may have to be re-evaluated if the lifetime is configurable per use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants