Always pretty print binary values in table
#12294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanManske
added
pr:breaking-change
|
I was worried that this would break some of the |
|
Verified fixed in nushell/nushell.github.io#1312! @IanManske That was inhumanly fast you're a hero 🎖️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Binary values passed to
tablemay or may not be pretty formatted based on the output destination. This leads to weird behavior as documented in #12287. This PR changestableto always pretty print binary values. However, binary values passed to external commands will not be formatted (this is the existing behavior).User-Facing Changes
This is a breaking change. E.g.:
used to print raw bytes, but it will now print the pretty formatted bytes.
After Submitting
Add to 0.92.0 release notes and update documentation.