Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document wrap behavior with index #1572

Closed
wants to merge 1 commit into from
Closed

Conversation

AlifianK
Copy link

@AlifianK AlifianK commented Oct 1, 2024

No description provided.

@fdncred
Copy link
Collaborator

fdncred commented Oct 1, 2024

Thanks, but it's the same for this command. It must be changed in the rust code to show up in the docs.

@fdncred fdncred closed this Oct 1, 2024
@NotTheDr01ds
Copy link
Contributor

Also a good point, at least that consecutive, 1-based numbers are probably a bad example to use for wrap, at least. I wish I'd seen this before I committed the other.

I think for this one, I'll do something a bit different, though:

[ Pachisi Mahjong Catan Carcassonne ] | wrap games

As for the index column name being magic - I agree this is confusing. See my comment in your main repo issue. @sholderbach has suggested potentially removing the "auto-renaming" feaure.

IanManske pushed a commit to nushell/nushell that referenced this pull request Oct 2, 2024
# Description

As with #13985, credit to @AlifianK for suggesting this in
nushell/nushell.github.io#1572

Updates the example in `wrap` to not use 1-based, sequential numbers.

# User-Facing Changes

Help/doc only

# Tests + Formatting

- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`

# After Submitting

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants