Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yadm completions to the repo #960

Merged
merged 7 commits into from
Sep 25, 2024
Merged

feat: add yadm completions to the repo #960

merged 7 commits into from
Sep 25, 2024

Conversation

louiss0
Copy link
Contributor

@louiss0 louiss0 commented Sep 24, 2024

This is a request to add yadm completions to the repo.
These resemble the ones that are written for. The git one in your repo.
Yadm is a dotfiles manager that leverages git but uses your home directory by default.

To see the tool go to https://yadm.io/docs/overview

@fdncred
Copy link
Collaborator

fdncred commented Sep 24, 2024

Thanks! It seems like the formatting isn't great. Lots of extra newlines, indention is inconsistent. I'm also thinking much of the completions are duplicated in the module, but I didn't check line by line. If you could clean this stuff up, we can land this PR.

@louiss0
Copy link
Contributor Author

louiss0 commented Sep 24, 2024

Thanks! It seems like the formatting isn't great. Lots of extra newlines, indention is inconsistent. I'm also thinking much of the completions are duplicated in the module, but I didn't check line by line. If you could clean this stuff up, we can land this PR.

This file is huge. I tried to find a formatter to use for nu shell but falied. I don't know what to do.
I really put some effort into formatting. But I don't think I got everything.

Can you please help?

@fdncred
Copy link
Collaborator

fdncred commented Sep 24, 2024

we don't have a stable formatter, but you could try nufmt to see how it goes.

@louiss0
Copy link
Contributor Author

louiss0 commented Sep 25, 2024

we don't have a stable formatter, but you could try nufmt to see how it goes.

How do I install it?

@fdncred
Copy link
Collaborator

fdncred commented Sep 25, 2024

You have to clone the repo and build it right now.

@louiss0
Copy link
Contributor Author

louiss0 commented Sep 25, 2024

You have to clone the repo and build it right now.

I did it only made things worse.
I had to also use the file path to execute it.
I thought it would automatically allow me to do nufmt. I couldn't

@louiss0
Copy link
Contributor Author

louiss0 commented Sep 25, 2024

Can you please make some suggestions?
The file isn't too long

@fdncred
Copy link
Collaborator

fdncred commented Sep 25, 2024

it looks better now than before plus you removed one file that looked mostly duplicated.

@louiss0
Copy link
Contributor Author

louiss0 commented Sep 25, 2024

it looks better now than before plus you removed one file that looked mostly duplicated.

I'm glad! I want this one to be finished so that i could submit another PR

@fdncred fdncred merged commit 5ffdfca into nushell:main Sep 25, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Sep 25, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants