Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
color_config
's (non-Lemnos) are moved to the./src/custom-nu-themes
directory and used to generate the main theme files when doing a./make.nu
make.nu
and other scripts (e.g. preview) have been moved to thesrc
directoryREADME
for thesrc
scriptsREADME
updated for clarity@amtoine Thanks for your suggestions on the
README
. I've pretty extensively changed the flow, so please re-review and let me know how it looks. Also note that I haven't personally tested with Nupm, so please especially review this section. Thanks!@fdncred CC
Still planning on working on the preview scripts next. They'll need only slight changes to run (probably a path change), but they can be simplified a bit now, I hope. At the same time, I'll complicate them in other ways ;-).
Note that there is a bug in both
nushell-dark
andnushell-light
that prevented the terminal colors from being updated regardless. You can see that in the existing screenshots, where both those themes simply re-use the previous theme (alphabetically's) background. I haven't fixed this yet.