-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nu-themes
package
#899
Conversation
|
yeah, but when i run the following source nu-themes/dracula.nu it immediately changes the theme to Dracula for me then, the following does not appear to change anything, that's why im not sure i fully understand this command 😉 use nu-themes/dracula.nu
dracula update terminal |
Correct. This is a bug that @NotTheDr01ds has filed. nushell/nushell#13403 |
@amtoine Perhaps I need to make the Before the change:
After the change:
As for this PR - I'm in the process of updating the old themes (manual) so that they work like the updated ones do. While I'm fine with the "old" ones going in temporarily, I'm working on making sure that they don't get lost again by having their generation be part of the |
Not quite - The behavior that @amtoine describes is correct. If you |
oooooooh, i understand now @NotTheDr01ds !! your explanation is much much clearer, thanks a lot 🙏
|
@amtoine A couple of questions:
|
yup, we can do that, thanks @NotTheDr01ds 🙏 |
description
this PR puts back a few themes that have been removed in the previous PR and fixes the commands in the README.
a few questions
@NotTheDr01ds, i have a few questions too :)
activate
module? why not directly put theexport-env
in the module?update terminal
command, what does it do?