Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specificity of error message, changing directory from initial state #6032

Open
nus-se-script opened this issue Nov 17, 2023 · 1 comment
Open

Comments

@nus-se-script
Copy link

nus-se-script commented Nov 17, 2023

image.png

When typing cd from the initial state, the error message recieved is "provided path cannot be resolved against the current path".

image.png

Above is what I would expect the behaviour to be, similar to how the CLI works. It should ideally not throw an error message to the user, when in fact the command entered is valid.


[original: nus-cs2103-AY2324S1/pe-interim#6034] [original labels: severity.Low type.FeatureFlaw]
@Nid21cs
Copy link
Contributor

Nid21cs commented Nov 18, 2023

Team's Response

  • In our application ~ is both our root directory as well as home directory. We used the term root directory to inform users that there is no directory above it.
  • At the same time we wanted to give more descriptive message to explain why the command does not achieve any results as compared to the CLI.
  • As mentioned in UG, there is no directory above the root directory, the only navigable directories are root and group, and hence trying to navigate above it shows an error message.
  • In this case of unix, we are unsure if cd .. at the root directory is a valid command, but in our application we decided to make it an invalid command and made it clear in the UG, and hence decided an invalid command should have an error message shown.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants