Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[toolbox] Add Faraday constant to math toolbox #2137

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Arthur-GYT
Copy link

@Arthur-GYT Arthur-GYT changed the title Add Faraday constant to math toolbox [toolbox] Add Faraday constant to math toolbox Jan 5, 2024
@Arthur-GYT
Copy link
Author

I convert this PR as a draft until I resolved rebase problems ^^'

@Arthur-GYT
Copy link
Author

Arthur-GYT commented Jan 18, 2024

@FelixNumworks I have an error to rebase this branch with epsilon-core submodule. Any idea how I can do a rebase properly ?

@MarcNumworks
Copy link
Contributor

Hi Arthur-GYT,
if I am correct the only thing you have to do is to run git rebase 21.3.0 --onto 22.2.0 on your branch.

I hope it will work for you 😄

@Arthur-GYT Arthur-GYT force-pushed the apps/calculation/faraday-constant branch from c253943 to 3ed5338 Compare January 18, 2024 14:12
@CLAassistant
Copy link

CLAassistant commented Jan 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ FelixNumworks
✅ MarcNumworks
❌ Arthur-GYT


Arthur-GYT seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Arthur-GYT
Copy link
Author

Hi Arthur-GYT, if I am correct the only thing you have to do is to run git rebase 21.3.0 --onto 22.2.0 on your branch.

I hope it will work for you 😄

Hi @MarcNumworks

Thanks for your answer, it work ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants