Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add infrastructure to simplify unicode/StringDType promoters #27671

Open
ngoldbaum opened this issue Oct 30, 2024 · 0 comments
Open

ENH: Add infrastructure to simplify unicode/StringDType promoters #27671

ngoldbaum opened this issue Oct 30, 2024 · 0 comments

Comments

@ngoldbaum
Copy link
Member

ngoldbaum commented Oct 30, 2024

Originally from a comment by @seberg: #27636 (review)

The one story that I could potentially see is to make something like an abstract (doesn't need to be an actual thing could just be a tuple as in isinstance, but conceptually):

class StringOrUnicodeDType:

so that we could just add one promoter, but the promoter would be need to programmatically decide whether the result should be unicode or string. (Similar to the "this dtype must occur", style of logic. But these ufuncs that include ints show that just a list of dtypes is not super helpful a such)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant