Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the effect in the Jenkins pipeline of user manually setting desiredPhase=Paused? #269

Open
juliev0 opened this issue Sep 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Sep 14, 2024

Summary

I believe the Pipeline will remain "Suspended" according to the lua script, since Pipeline Condition.PausingOrPaused remains true. Does this mean the Jenkins pipeline will fail?

If so, we should change it from looking for the Condition to instead looking for phase==Pending. This should get set to "Deployed" once the spec is deployed, independent of the fact that it's still pausing.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 14, 2024

cc @xdevxy

@juliev0
Copy link
Collaborator Author

juliev0 commented Sep 16, 2024

@dpadhiar can you verify the Jenkins pipeline will be okay with getting "Suspended" back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants