Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wavefront fetcher #413

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat: wavefront fetcher #413

merged 3 commits into from
Sep 18, 2024

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Sep 17, 2024

Introducing a wavefront data fetcher.
Supports simple metric based queries as well as raw queries.

Signed-off-by: Avik Basu <[email protected]>
@ab93 ab93 self-assigned this Sep 17, 2024
@ab93 ab93 added the enhancement New feature or request label Sep 17, 2024
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
@ab93 ab93 marked this pull request as ready for review September 17, 2024 01:42
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (f6ce546) to head (5f9f2ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
numalogic/connectors/wavefront.py 94.54% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   92.18%   92.22%   +0.03%     
==========================================
  Files          97       98       +1     
  Lines        4775     4833      +58     
  Branches      429      437       +8     
==========================================
+ Hits         4402     4457      +55     
- Misses        276      277       +1     
- Partials       97       99       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@calvinx408 calvinx408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

numalogic/connectors/wavefront.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@s0nicboOm s0nicboOm enabled auto-merge (squash) September 18, 2024 18:41
@s0nicboOm s0nicboOm merged commit ed81ef0 into main Sep 18, 2024
13 checks passed
@s0nicboOm s0nicboOm deleted the wavefront-fetcher branch September 18, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants