fix: test_mlflow_registry #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 92.18% 92.22% +0.03%
==========================================
Files 97 97
Lines 4775 4811 +36
Branches 429 434 +5
==========================================
+ Hits 4402 4437 +35
+ Misses 276 275 -1
- Partials 97 99 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: yleilawang <[email protected]>
s0nicboOm
requested changes
Sep 18, 2024
Comment on lines
18
to
+20
| import mlflow.pyfunc | ||
| import mlflow.pytorch | ||
| import mlflow.sklearn |
There was a problem hiding this comment.
As discussed, I don't think we need this anymore.
Just import mlflow should work.
|
not needed, new PR created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There existed errors in test logs while test cases still passed. One example is the ConnectionError due to not mocking mlflow function calls properly.
Fixed through modifying a few syntax for patch mock calls. The test cases should pass with no logging errors now.