Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support sklearn BaseEstimators #407

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: support sklearn BaseEstimators #407

merged 3 commits into from
Sep 4, 2024

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Sep 4, 2024

The transformers and threshold model inherit BaseEstimator class.

Fixes:

mlflow saving of models

@s0nicboOm s0nicboOm marked this pull request as ready for review September 4, 2024 21:38
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (eb9ceb1) to head (abc39d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   92.11%   92.15%   +0.04%     
==========================================
  Files          97       97              
  Lines        4782     4782              
  Branches      430      430              
==========================================
+ Hits         4405     4407       +2     
+ Misses        279      278       -1     
+ Partials       98       97       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ab93 ab93 merged commit aa3b4bb into main Sep 4, 2024
13 checks passed
@ab93 ab93 deleted the mlflow_fix branch September 4, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants