chore: some initial code for side inputs manager #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
vigith
approved these changes
Jul 19, 2023
pkg/sideinputs/manager/manager.go
Outdated
| @@ -65,11 +67,56 @@ func (sim *sideInputsManager) Start(ctx context.Context) error { | |||
| return fmt.Errorf("unrecognized isbsvc type %q", sim.isbSvcType) | |||
| } | |||
|
|
|||
| // TODO(SI): do something | |||
| // Periodically call the ud container and write data to the store. | |||
| // TODO: remove it. | |||
There was a problem hiding this comment.
Suggested change
| // TODO: remove it. | |
| // TODO(SI): remove it. |
easy to search later?
jy4096
reviewed
Jul 19, 2023
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what this PR does.