fix: remove retry when the processor is not found. #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yhl25
commented
Jul 18, 2023
•
yhl25
commented
- we shouldn't retry when the processor is not found, it will slow down the watermark progression because the watchers will be busy retrying.
- panic if there are any reduce errors, so that we replay the messages when the pod comes up.
Signed-off-by: Yashash H L <[email protected]>
yhl25
changed the title
Signed-off-by: Yashash H L <[email protected]>
KeranYang
reviewed
Jul 18, 2023
Signed-off-by: Yashash H L <[email protected]>
KeranYang
approved these changes
Jul 19, 2023
vigith
approved these changes
Jul 19, 2023
| "github.com/numaproj/numaflow/pkg/shared/logging" | ||
| "github.com/numaproj/numaflow/pkg/watermark/store" | ||
| "github.com/numaproj/numaflow/pkg/watermark/wmb" | ||
| "go.uber.org/zap" |
Signed-off-by: Yashash H L <[email protected]> Co-authored-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
jy4096
approved these changes
Jul 19, 2023
|
we merged this with a failed check, could you please make sure it is not retrogressing? |
KeranYang
added a commit
to KeranYang/numaflow
that referenced
this pull request
Jul 20, 2023
)" This reverts commit a02f29a.
KeranYang
added a commit
to KeranYang/numaflow
that referenced
this pull request
Jul 20, 2023
…umaproj#868)"" This reverts commit cf8a7d5.
yhl25
added a commit
to yhl25/numaflow
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.