fix: incorrect side inputs watch logic #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Oct 5, 2023
| @@ -132,9 +132,6 @@ func startSideInputInitializer(ctx context.Context, store kvs.KVStorer, mountPat | |||
| // gotAllSideInputVals checks if values for all side-inputs | |||
| // have been received from the KV bucket | |||
| func gotAllSideInputVals(sideInputs []string, m map[string][]byte) bool { | |||
| if len(sideInputs) != len(m) { | |||
There was a problem hiding this comment.
len(m) is total number of side inputs defined in the pipeline, len(sideInputs) is the number of side inputs current vertex is watching.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Oct 5, 2023
| @@ -110,9 +110,9 @@ func startSideInputInitializer(ctx context.Context, store kvs.KVStorer, mountPat | |||
| m[value.Key()] = value.Value() | |||
| // Wait for the data to be ready in the side input store, and then copy it to the disk | |||
| if gotAllSideInputVals(sideInputs, m) { | |||
| for sideInput := range m { | |||
| for _, sideInput := range sideInputs { | |||
There was a problem hiding this comment.
Should only populate the side inputs that current vertex is watching.
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Oct 5, 2023
| return | ||
| case value := <-watchCh: | ||
| if value == nil { | ||
| log.Warnw("nil value received from Side Input watcher") | ||
| continue | ||
| } | ||
| if !sharedutil.StringSliceContains(sideInputs, value.Key()) { |
There was a problem hiding this comment.
Ignore the ones that current vertex is not watching.
whynowy
changed the title
vigith
approved these changes
Oct 5, 2023
kohlisid
approved these changes
Oct 5, 2023
jy4096
approved these changes
Oct 5, 2023
whynowy
added a commit
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1160