Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: re-arrange some of the rater implementations #1036

Merged
merged 3 commits into from
Sep 12, 2023
Merged

refactor: re-arrange some of the rater implementations #1036

merged 3 commits into from
Sep 12, 2023

Conversation

KeranYang
Copy link
Member

  • Add one more unit test to cover the case when a single pod is serving multiple partitions.
  • Refactor the vertex type key usage by making them const and shared between the pod tracker and rater.
  • Fix a TODO to make userSpecifiedLookbackSecond static instead of being figured out dynamically every time getRates gets called.
  • Break early when looping through the metric label list to find the partition name.

@KeranYang KeranYang changed the title refactor: re-arrange some of hte rater implementations refactor: re-arrange some of the rater implementations Sep 11, 2023
@KeranYang KeranYang marked this pull request as ready for review September 11, 2023 21:09
whynowy
whynowy approved these changes Sep 11, 2023
View reviewed changes
pkg/daemon/server/service/rater/helper.go Outdated
// The following string set is used to identify the vertex type of pod

// KeyVertexTypeReduce is the vertex type string for reduce vertex
KeyVertexTypeReduce = "reduce"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it private?

@KeranYang KeranYang enabled auto-merge (squash) September 12, 2023 01:14
@KeranYang KeranYang merged commit c12e909 into numaproj:main Sep 12, 2023
17 checks passed
@KeranYang KeranYang deleted the r-fix branch September 12, 2023 01:52
whynowy pushed a commit that referenced this pull request Sep 15, 2023
@KeranYang @whynowy
refactor: re-arrange some of the rater implementations (#1036)
8cbb4d6 
Signed-off-by: Keran Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

@vigith vigith Awaiting requested review from vigith vigith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KeranYang @whynowy