From 17bd2f23874ed5958d6bef148d591d0b7bc01d6c Mon Sep 17 00:00:00 2001 From: Derek Wang Date: Tue, 3 Oct 2023 10:09:30 -0700 Subject: [PATCH] chore: adjust buckets for histogram metrics (#1145) Signed-off-by: Derek Wang --- pkg/forward/metrics.go | 6 +++--- pkg/sinks/forward/metrics.go | 2 +- pkg/sources/forward/metrics.go | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/forward/metrics.go b/pkg/forward/metrics.go index 75d11be07c..d705852f49 100644 --- a/pkg/forward/metrics.go +++ b/pkg/forward/metrics.go @@ -119,7 +119,7 @@ var forwardAChunkProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO Subsystem: "forwarder", Name: "forward_chunk_processing_time", Help: "Processing times of the entire forward a chunk (100 microseconds to 20 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) // udfProcessingTime is a histogram to Observe UDF Processing times as a whole @@ -127,7 +127,7 @@ var udfProcessingTime = promauto.NewHistogramVec(prometheus.HistogramOpts{ Subsystem: "forwarder", Name: "udf_processing_time", Help: "Processing times of UDF (100 microseconds to 15 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) // concurrentUDFProcessingTime is a histogram to Observe UDF Processing times as a whole @@ -135,7 +135,7 @@ var concurrentUDFProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO Subsystem: "forwarder", Name: "concurrent_udf_processing_time", Help: "Processing times of Concurrent UDF (100 microseconds to 20 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) // udfReadMessagesCount is used to indicate the number of messages read by UDF diff --git a/pkg/sinks/forward/metrics.go b/pkg/sinks/forward/metrics.go index 2a7925e531..9409b7f864 100644 --- a/pkg/sinks/forward/metrics.go +++ b/pkg/sinks/forward/metrics.go @@ -112,5 +112,5 @@ var forwardAChunkProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO Subsystem: "sink_forwarder", Name: "forward_chunk_processing_time", Help: "Processing times of the entire forward a chunk (100 microseconds to 20 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) diff --git a/pkg/sources/forward/metrics.go b/pkg/sources/forward/metrics.go index f9a7305637..8d11f315d2 100644 --- a/pkg/sources/forward/metrics.go +++ b/pkg/sources/forward/metrics.go @@ -112,7 +112,7 @@ var forwardAChunkProcessingTime = promauto.NewHistogramVec(prometheus.HistogramO Subsystem: "source_forwarder", Name: "forward_chunk_processing_time", Help: "Processing times of the entire forward a chunk (100 microseconds to 20 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) // transformerProcessingTime is a histogram to Observe Source Transformer Processing times as a whole @@ -120,7 +120,7 @@ var transformerProcessingTime = promauto.NewHistogramVec(prometheus.HistogramOpt Subsystem: "source_forwarder", Name: "transformer_processing_time", Help: "Processing times of source transformer (100 microseconds to 15 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*15, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) // concurrentTransformerProcessingTime is a histogram to Observe Source Transformer Processing times as a whole @@ -128,7 +128,7 @@ var concurrentTransformerProcessingTime = promauto.NewHistogramVec(prometheus.Hi Subsystem: "source_forwarder", Name: "concurrent_transformer_processing_time", Help: "Processing times of Concurrent source transformer (100 microseconds to 20 minutes)", - Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 60), + Buckets: prometheus.ExponentialBucketsRange(100, 60000000*20, 10), }, []string{metrics.LabelVertex, metrics.LabelPipeline, metrics.LabelPartitionName}) // transformerReadMessagesCount is used to indicate the number of messages read by source transformer